Apply go fix modernizations

artnet.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"net"
+	"slices"
 	"sort"
 	"strings"
 	"time"
@@ -28,7 +29,6 @@ func (h *artnetHandler) HandlePollReply(src *net.UDPAddr, pkt *artnet.PollReplyP
 	h.discovery.HandlePollReply(src, pkt)
 }
 
-
 func (t *Tendrils) startArtNet(ctx context.Context, iface net.Interface) {
 	srcIP, broadcast := getInterfaceIPv4(iface)
 	if srcIP == nil || broadcast == nil {
@@ -124,7 +124,6 @@ func (n *Nodes) UpdateArtNet(node *Node, inputs, outputs []int) {
 	}
 }
 
-
 func (n *Nodes) expireArtNet() {
 	for _, node := range n.nodes {
 		if node.ArtNetInputs != nil {
@@ -197,7 +196,7 @@ func (n *Nodes) logArtNet() {
 			seen[u] = true
 		}
 	}
-	sort.Slice(allUniverses, func(i, j int) bool { return allUniverses[i] < allUniverses[j] })
+	slices.Sort(allUniverses)
 
 	log.Printf("[sigusr1] ================ %d artnet universes ================", len(allUniverses))
 	for _, u := range allUniverses {

bmd.go

@@ -211,9 +211,9 @@ func (t *Tendrils) probeHyperDeck(ip net.IP) string {
 	}
 
 	response := string(buf[:n])
-	for _, line := range strings.Split(response, "\r\n") {
+	for line := range strings.SplitSeq(response, "\r\n") {
-		if strings.HasPrefix(line, "model: ") {
+		if after, ok := strings.CutPrefix(line, "model: "); ok {
-			model := strings.TrimPrefix(line, "model: ")
+			model := after
 			if t.DebugBMD {
 				log.Printf("[bmd] hyperdeck %s at %s", model, ip)
 			}
@@ -238,9 +238,9 @@ func (t *Tendrils) probeVideoHub(ip net.IP) string {
 	}
 
 	response := string(buf[:n])
-	for _, line := range strings.Split(response, "\n") {
+	for line := range strings.SplitSeq(response, "\n") {
-		if strings.HasPrefix(line, "Model name: ") {
+		if after, ok := strings.CutPrefix(line, "Model name: "); ok {
-			model := strings.TrimSpace(strings.TrimPrefix(line, "Model name: "))
+			model := strings.TrimSpace(after)
 			if t.DebugBMD {
 				log.Printf("[bmd] videohub %s at %s", model, ip)
 			}

dante.go

@@ -527,7 +527,7 @@ func (t *Tendrils) queryDanteTxChannels(conn *net.UDPConn, ip net.IP, txCount in
 	}
 
 	pagesNeeded := (txCount + 15) / 16
-	for page := 0; page < pagesNeeded; page++ {
+	for page := range pagesNeeded {
 		pageNum := byte(page + 1)
 		args := []byte{0x00, 0x01, 0x00, pageNum, 0x00, 0x00}
 
@@ -551,7 +551,7 @@ func (t *Tendrils) queryDanteSubscriptions(conn *net.UDPConn, ip net.IP, rxCount
 	hasMulticast := false
 
 	pagesNeeded := (rxCount + 15) / 16
-	for page := 0; page < pagesNeeded; page++ {
+	for page := range pagesNeeded {
 		pageNum := byte(page + 1)
 		args := []byte{0x00, 0x01, 0x00, pageNum, 0x00, 0x00}
 
@@ -582,7 +582,7 @@ func (t *Tendrils) queryDanteSubscriptions(conn *net.UDPConn, ip net.IP, rxCount
 				}
 			}
 			recordOffset := 12
-			for idx := 0; idx < subCount; idx++ {
+			for idx := range subCount {
 				if recordOffset+20 > len(resp) {
 					break
 				}
@@ -612,7 +612,7 @@ func (t *Tendrils) queryDanteSubscriptions(conn *net.UDPConn, ip net.IP, rxCount
 			}
 		} else {
 			recordOffset := 14
-			for idx := 0; idx < subCount; idx++ {
+			for idx := range subCount {
 				if recordOffset+10 > len(resp) {
 					break
 				}
@@ -663,7 +663,7 @@ func (t *Tendrils) queryDanteSubscriptions3400(conn *net.UDPConn, ip net.IP, rxC
 
 	pagesNeeded := (rxCount + 15) / 16
 	startChannel := 1
-	for page := 0; page < pagesNeeded; page++ {
+	for page := range pagesNeeded {
 		pageNum := page + 1
 		args := make([]byte, 24)
 		args[7] = 0x01

errors.go

@@ -29,7 +29,7 @@ type Error struct {
 	Utilization float64   `json:"utilization,omitempty"`
 	FirstSeen   time.Time `json:"first_seen"`
 	LastSeen    time.Time `json:"last_seen"`
-	LastUpdated time.Time `json:"last_updated,omitempty"`
+	LastUpdated time.Time `json:"last_updated,omitzero"`
 }
 
 type ErrorTracker struct {

mdns.go

@@ -46,8 +46,8 @@ func extractNetaudioChanDevice(s string) string {
 		return ""
 	}
 	name := strings.ReplaceAll(s[:idx], "\\", "")
-	if atIdx := strings.Index(name, "@"); atIdx >= 0 {
+	if _, after, ok := strings.Cut(name, "@"); ok {
-		return name[atIdx+1:]
+		return after
 	}
 	return ""
 }
@@ -235,7 +235,7 @@ func (t *Tendrils) sendMDNSQueries(ifaceName string, conn *net.UDPConn) {
 	dest := &net.UDPAddr{IP: net.IPv4(224, 0, 0, 251), Port: 5353}
 
 	n := len(mdnsServices)
-	for i := 0; i < n; i++ {
+	for i := range n {
 		service := mdnsServices[(i+mdnsQueryOffset)%n]
 		msg := new(dns.Msg)
 		msg.SetQuestion(service, dns.TypePTR)

nodes.go

@@ -5,6 +5,7 @@ import (
 	"fmt"
 	"log"
 	"net"
+	"slices"
 	"sort"
 	"strings"
 	"sync"
@@ -133,12 +134,7 @@ func (n *Nodes) isSharedName(name string) bool {
 	if n.t.config == nil {
 		return false
 	}
-	for _, shared := range n.t.config.SharedNames {
+	return slices.Contains(n.t.config.SharedNames, name)
-		if shared == name {
-			return true
-		}
-	}
-	return false
 }
 
 func (n *Nodes) createNode() *Node {

sacn_discovery.go

@@ -17,7 +17,7 @@ func (t *Tendrils) startSACNDiscoveryListener(ctx context.Context, iface net.Int
 	}
 	defer receiver.Stop()
 
-	receiver.SetHandler(func(src *net.UDPAddr, pkt interface{}) {
+	receiver.SetHandler(func(src *net.UDPAddr, pkt any) {
 		if disc, ok := pkt.(*sacn.DiscoveryPacket); ok {
 			t.handleSACNDiscoveryPacket(src.IP, disc)
 		}

snmp.go

@@ -52,7 +52,7 @@ func defaultSNMPConfig() *snmpConfig {
 	}
 }
 
-func snmpToInt(val interface{}) (int, bool) {
+func snmpToInt(val any) (int, bool) {
 	switch v := val.(type) {
 	case int:
 		return v, true

tendrils.go

@@ -21,7 +21,7 @@ func getInterfaceIPv4(iface net.Interface) (srcIP, broadcast net.IP) {
 			srcIP = ipnet.IP.To4()
 			mask := ipnet.Mask
 			broadcast = make(net.IP, 4)
-			for i := 0; i < 4; i++ {
+			for i := range 4 {
 				broadcast[i] = srcIP[i] | ^mask[i]
 			}
 			return srcIP, broadcast

types.go

@@ -6,6 +6,7 @@ import (
 	"fmt"
 	"math"
 	"net"
+	"slices"
 	"sort"
 	"strings"
 	"time"
@@ -57,7 +58,7 @@ func (s ArtNetUniverseSet) Universes() []ArtNetUniverse {
 	for u := range s {
 		result = append(result, u)
 	}
-	sort.Slice(result, func(i, j int) bool { return result[i] < result[j] })
+	slices.Sort(result)
 	return result
 }
 
@@ -91,7 +92,7 @@ func (s SACNUniverseSet) Universes() []SACNUniverse {
 	for u := range s {
 		result = append(result, u)
 	}
-	sort.Slice(result, func(i, j int) bool { return result[i] < result[j] })
+	slices.Sort(result)
 	return result
 }
 
@@ -268,7 +269,7 @@ func (s MulticastMembershipSet) SACNInputs() []SACNUniverse {
 			result = append(result, g.SACNUniverse)
 		}
 	}
-	sort.Slice(result, func(i, j int) bool { return result[i] < result[j] })
+	slices.Sort(result)
 	return result
 }
 
@@ -703,11 +704,12 @@ func (i *Interface) String() string {
 		parts = append(parts, i.Stats.String())
 	}
 
-	result := parts[0]
+	var result strings.Builder
+	result.WriteString(parts[0])
 	for _, p := range parts[1:] {
-		result += " " + p
+		result.WriteString(" " + p)
 	}
-	return result
+	return result.String()
 }
 
 func (s *InterfaceStats) String() string {