diff --git a/firmware/include/dispatch.h b/firmware/include/dispatch.h index d9817b3..2ff8f4f 100644 --- a/firmware/include/dispatch.h +++ b/firmware/include/dispatch.h @@ -5,6 +5,7 @@ #include #include #include "wire.h" +#include "timer_queue.h" struct responder { uint32_t message_id; @@ -45,5 +46,6 @@ void typed_handler(responder resp, std::span payload) { } void dispatch_init(); -void dispatch_schedule_ms(uint32_t ms, std::function fn); +timer_handle dispatch_schedule_ms(uint32_t ms, std::function fn); +bool dispatch_cancel_timer(timer_handle h); [[noreturn]] void dispatch_run(std::span handlers); diff --git a/firmware/include/sorted_list.h b/firmware/include/sorted_list.h index 96e5ca8..b78f732 100644 --- a/firmware/include/sorted_list.h +++ b/firmware/include/sorted_list.h @@ -28,8 +28,8 @@ struct sorted_list { T& front() { return head->value(); } const T& front() const { return head->value(); } - void insert(T value) { - if (full()) return; + node* insert(T value) { + if (full()) return nullptr; node* n = free_head; free_head = n->next; new (n->storage) T(std::move(value)); @@ -37,7 +37,7 @@ struct sorted_list { if (!head || n->value() < head->value()) { n->next = head; head = n; - return; + return n; } node* cur = head; @@ -45,6 +45,7 @@ struct sorted_list { cur = cur->next; n->next = cur->next; cur->next = n; + return n; } void pop_front() { @@ -55,4 +56,21 @@ struct sorted_list { n->next = free_head; free_head = n; } + + bool remove(node* target) { + if (!target || empty()) return false; + if (head == target) { + pop_front(); + return true; + } + node* cur = head; + while (cur->next && cur->next != target) + cur = cur->next; + if (cur->next != target) return false; + cur->next = target->next; + target->value().~T(); + target->next = free_head; + free_head = target; + return true; + } }; diff --git a/firmware/include/timer_queue.h b/firmware/include/timer_queue.h index 1a2ea52..2d07e13 100644 --- a/firmware/include/timer_queue.h +++ b/firmware/include/timer_queue.h @@ -12,18 +12,27 @@ inline bool operator<(const timer_entry& a, const timer_entry& b) { return absolute_time_diff_us(b.when, a.when) < 0; } +using timer_handle = sorted_list::node*; + struct timer_queue { sorted_list queue; alarm_id_t alarm = -1; volatile bool irq_pending = false; - void schedule(absolute_time_t when, std::function fn) { - queue.insert({when, std::move(fn)}); + timer_handle schedule(absolute_time_t when, std::function fn) { + auto* n = queue.insert({when, std::move(fn)}); arm(); + return n; } - void schedule_ms(uint32_t ms, std::function fn) { - schedule(make_timeout_time_ms(ms), std::move(fn)); + timer_handle schedule_ms(uint32_t ms, std::function fn) { + return schedule(make_timeout_time_ms(ms), std::move(fn)); + } + + bool cancel(timer_handle h) { + bool removed = queue.remove(h); + if (removed) arm(); + return removed; } void run() { diff --git a/firmware/lib/dispatch.cpp b/firmware/lib/dispatch.cpp index 4009070..9198a97 100644 --- a/firmware/lib/dispatch.cpp +++ b/firmware/lib/dispatch.cpp @@ -17,8 +17,12 @@ void dispatch_init() { dlog("dispatch_init complete"); } -void dispatch_schedule_ms(uint32_t ms, std::function fn) { - timers.schedule_ms(ms, std::move(fn)); +timer_handle dispatch_schedule_ms(uint32_t ms, std::function fn) { + return timers.schedule_ms(ms, std::move(fn)); +} + +bool dispatch_cancel_timer(timer_handle h) { + return timers.cancel(h); } [[noreturn]] void dispatch_run(std::span handlers) { diff --git a/firmware/lib/test_handlers.cpp b/firmware/lib/test_handlers.cpp index eab26ca..4232013 100644 --- a/firmware/lib/test_handlers.cpp +++ b/firmware/lib/test_handlers.cpp @@ -30,27 +30,24 @@ static void test_ping(const responder& resp, ipv4::ip4_addr dst_ip) { ipv4::ip4_addr our_ip = ns.ip; - auto done = std::make_shared(false); + auto timer = std::make_shared(nullptr); auto cb = std::make_shared)>>(); - *cb = [resp, ping_id, our_ip, done, cb](std::span frame) { - if (*done) return; + *cb = [resp, ping_id, our_ip, timer, cb](std::span frame) { ipv4::ip4_addr src_ip; if (!icmp::parse_echo_reply(frame, src_ip, ping_id)) { net_add_frame_callback(*cb); return; } + dispatch_cancel_timer(*timer); if (src_ip == our_ip) { - net_add_frame_callback(*cb); + resp.respond(ResponseTest{false, {"got reply from self: " + ipv4::to_string(src_ip)}}); return; } - *done = true; resp.respond(ResponseTest{true, {"reply from " + ipv4::to_string(src_ip)}}); }; net_add_frame_callback(*cb); - dispatch_schedule_ms(5000, [resp, done]() { - if (*done) return; - *done = true; + *timer = dispatch_schedule_ms(5000, [resp]() { resp.respond(ResponseTest{false, {"no reply from non-self host within 5s"}}); }); }