theater/cabletest
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove CPU pinning flags that measured slower than the scheduler

Browse Source
This commit is contained in:
flamingcow
2026-07-25 19:24:10 -07:00
parent 32c49ccc4b
commit abb8b81919
4 changed files with 2 additions and 58 deletions
Download Patch File Download Diff File Expand all files Collapse all files
main.go
+2 -40
View File
@@ -99,28 +99,6 @@ func parseSizes(s string) ([]int, error) {
return out, nil
}
func parseCPUs(s string) ([]int, error) {
if strings.TrimSpace(s) == "" {
return nil, nil
}
var out []int
for _, f := range strings.Split(s, ",") {
v, err := strconv.Atoi(strings.TrimSpace(f))
if err != nil {
return nil, fmt.Errorf("bad cpu %q: %w", f, err)
}
out = append(out, v)
}
return out, nil
}
func cpuAt(cpus []int, i int) int {
if len(cpus) == 0 {
return -1
}
return cpus[i%len(cpus)]
}
func (d *direction) snapshot() sample {
var s sample
for _, t := range d.txStats {
@@ -252,7 +230,6 @@ func (d *direction) start(wg *sync.WaitGroup, doneTx, doneRx *atomic.Bool, cfg c
stream: uint16(i),
spec: d.specs[i],
batch: cfg.batch,
cpu: cpuAt(cfg.txCPUs, i),
stats: d.txStats[i],
startTx: startTx,
}
@@ -266,7 +243,6 @@ func (d *direction) start(wg *sync.WaitGroup, doneTx, doneRx *atomic.Bool, cfg c
w := &rxWorker{
fd: fd,
batch: cfg.batch,
cpu: cpuAt(cfg.rxCPUs, i),
spec: d.specs[i],
stats: d.rxStats[i],
streams: d.streams,
@@ -293,8 +269,6 @@ func (d *direction) close() {
type config struct {
streams int
batch int
txCPUs []int
rxCPUs []int
}
func main() {
@@ -306,12 +280,10 @@ func main() {
streams = flag.Int("streams", 7, "independent streams per direction, capped by rx rings; each gets its own ethertype, steered by a flow rule to its own rx queue")
batch = flag.Int("batch", 64, "frames per sendmmsg/recvmmsg call")
duplex = flag.Bool("duplex", true, "run both directions simultaneously")
txCPUs = flag.String("txcpus", "", "comma-separated CPUs to pin tx workers to")
rxCPUs = flag.String("rxcpus", "", "comma-separated CPUs to pin rx workers to")
)
flag.Parse()
if err := run(*aName, *bName, *sizesArg, *patArg, *txCPUs, *rxCPUs,
if err := run(*aName, *bName, *sizesArg, *patArg,
*streams, *batch, *duplex); err != nil {
fmt.Fprintln(os.Stderr, "error:", err)
os.Exit(1)
@@ -320,7 +292,7 @@ func main() {
const reportInterval = 500 * time.Millisecond
func run(aName, bName, sizesArg, patArg, txCPUsArg, rxCPUsArg string,
func run(aName, bName, sizesArg, patArg string,
nStreams, batch int, duplex bool) error {
if aName == "" || bName == "" {
@@ -334,14 +306,6 @@ func run(aName, bName, sizesArg, patArg, txCPUsArg, rxCPUsArg string,
if err != nil {
return err
}
txCPUs, err := parseCPUs(txCPUsArg)
if err != nil {
return err
}
rxCPUs, err := parseCPUs(rxCPUsArg)
if err != nil {
return err
}
a, err := lookupEndpoint(aName)
if err != nil {
return err
@@ -387,8 +351,6 @@ func run(aName, bName, sizesArg, patArg, txCPUsArg, rxCPUsArg string,
cfg := config{
streams: nStreams,
batch: batch,
txCPUs: txCPUs,
rxCPUs: rxCPUs,
}
var dirs []*direction