Simplified API

This commit is contained in:
Ian Gulliver
2025-07-12 15:32:03 -07:00
parent 7d50eda620
commit a96b350b28
3 changed files with 175 additions and 179 deletions

View File

@@ -8,113 +8,96 @@ import (
"github.com/stretchr/testify/require"
)
func TestTaskPrompts(t *testing.T) {
service := taskcp.New("my_service")
project := service.AddProject()
task := project.InsertTaskBefore(-1).
WithTitle("Write unit tests").
WithInstructions("This is a test task.").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
return nil
})
successPrompt := task.SuccessPrompt()
require.Contains(t, successPrompt, "my_service.set_task_success")
require.Contains(t, successPrompt, fmt.Sprintf(`project_id=%d`, project.ID))
require.Contains(t, successPrompt, fmt.Sprintf(`task_id=%d`, task.ID))
failurePrompt := task.FailurePrompt()
require.Contains(t, failurePrompt, "my_service.set_task_failure")
require.Contains(t, failurePrompt, fmt.Sprintf(`project_id=%d`, project.ID))
require.Contains(t, failurePrompt, fmt.Sprintf(`task_id=%d`, task.ID))
}
func TestPlaceholderExpansion(t *testing.T) {
service := taskcp.New("my_service")
project := service.AddProject()
p := service.AddProject()
task1 := project.InsertTaskBefore(-1).
p.AddLastTask().
WithTitle("Please complete this task.").
WithInstructions("{SUCCESS_PROMPT}").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
Then(func(task *taskcp.Task) error {
return nil
})
require.Contains(t, task1.Instructions, "my_service.set_task_success")
require.NotContains(t, task1.Instructions, "{SUCCESS_PROMPT}")
task2 := project.InsertTaskBefore(-1).
task, err := p.PopNextTask()
require.NoError(t, err)
require.NotNil(t, task)
require.Contains(t, task.Instructions, "my_service.set_task_success")
require.NotContains(t, task.Instructions, "{SUCCESS_PROMPT}")
p.AddLastTask().
WithTitle("Try this risky operation.").
WithInstructions("{FAILURE_PROMPT}").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
Then(func(task *taskcp.Task) error {
return nil
})
require.Contains(t, task2.Instructions, "my_service.set_task_failure")
require.NotContains(t, task2.Instructions, "{FAILURE_PROMPT}")
task, err = p.PopNextTask()
require.NoError(t, err)
require.NotNil(t, task)
require.Contains(t, task.Instructions, "my_service.set_task_failure")
require.NotContains(t, task.Instructions, "{FAILURE_PROMPT}")
}
func TestTaskFlow(t *testing.T) {
service := taskcp.New("test_service")
project := service.AddProject()
p := service.AddProject()
var completed []int
var completed []string
task1 := project.InsertTaskBefore(-1).
p.AddLastTask().
WithTitle("First task").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
completed = append(completed, task.ID)
Then(func(task *taskcp.Task) error {
completed = append(completed, task.Title)
return nil
})
task2 := project.InsertTaskBefore(-1).
p.AddLastTask().
WithTitle("Second task").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
completed = append(completed, task.ID)
Then(func(task *taskcp.Task) error {
completed = append(completed, task.Title)
return nil
})
current := project.GetNextTask()
require.NotNil(t, current)
require.Equal(t, task1.ID, current.ID)
next, err := project.SetTaskSuccess(current.ID, "Task 1 done", "")
task1, err := p.PopNextTask()
require.NoError(t, err)
require.NotNil(t, next)
require.Equal(t, task2.ID, next.ID)
require.Equal(t, taskcp.TaskStateRunning, next.State)
require.NotNil(t, task1)
require.Equal(t, "First task", task1.Title)
next2, err := project.SetTaskFailure(next.ID, "Task 2 failed", "Error details")
task2, err := task1.SetSuccess("Task 1 done", "")
require.NoError(t, err)
require.Nil(t, next2)
require.NotNil(t, task2)
require.Equal(t, "Second task", task2.Title)
require.Equal(t, []int{task1.ID, task2.ID}, completed)
require.Equal(t, taskcp.TaskStateSuccess, project.Tasks[task1.ID].State)
require.Equal(t, taskcp.TaskStateFailure, project.Tasks[task2.ID].State)
task3, err := task2.SetFailure("Task 2 failed", "Error details")
require.NoError(t, err)
require.Nil(t, task3)
require.Equal(t, []string{"First task", "Second task"}, completed)
require.Equal(t, "Task 1 done", task1.Result)
require.Equal(t, "Task 2 failed", task2.Error)
}
func TestCallbackError(t *testing.T) {
service := taskcp.New("test_service")
project := service.AddProject()
p := service.AddProject()
expectedErr := fmt.Errorf("callback error")
task := project.InsertTaskBefore(-1).
p.AddLastTask().
WithTitle("Task with error callback").
WithInstructions("This is a test task.").
WithData("key", "value").
Then(func(project *taskcp.Project, task *taskcp.Task) error {
Then(func(task *taskcp.Task) error {
return expectedErr
})
current := project.GetNextTask()
require.NotNil(t, current)
require.Equal(t, task.ID, current.ID)
task, err := p.PopNextTask()
require.NoError(t, err)
require.NotNil(t, task)
require.Equal(t, "Task with error callback", task.Title)
_, err := project.SetTaskSuccess(current.ID, "Result", "")
require.Error(t, err)
require.Equal(t, expectedErr, err)
_, err = project.SetTaskFailure(current.ID, "Task failed", "")
_, err = task.SetSuccess("Result", "")
require.Error(t, err)
require.Equal(t, expectedErr, err)
}