patchy/elect
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Clear time separation for loss before gain

Browse Source
This commit is contained in:
Ian Gulliver
2023-06-04 13:59:06 -07:00
parent 7c3e760759
commit ed7ce91819
3 changed files with 43 additions and 18 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
elect_test.go
View File

@@ -13,7 +13,7 @@ func TestOne(t *testing.T) {
ts := NewTestSystem(t, 1)
defer ts.Stop()
require.Eventually(t, ts.Candidate(0).IsLeader, 15*time.Second, 100*time.Millisecond)
require.Eventually(t, ts.Candidate(0).IsLeader, 20*time.Second, 100*time.Millisecond)
}
func TestThree(t *testing.T) {
@@ -22,7 +22,7 @@ func TestThree(t *testing.T) {
ts := NewTestSystem(t, 3)
defer ts.Stop()
require.Eventually(t, ts.Candidate(0).IsLeader, 15*time.Second, 100*time.Millisecond)
require.Eventually(t, ts.Candidate(0).IsLeader, 20*time.Second, 100*time.Millisecond)
}
func TestFailover(t *testing.T) {
@@ -31,14 +31,14 @@ func TestFailover(t *testing.T) {
ts := NewTestSystem(t, 3)
defer ts.Stop()
require.Eventually(t, ts.Candidate(0).IsLeader, 15*time.Second, 100*time.Millisecond)
require.Eventually(t, ts.Candidate(0).IsLeader, 20*time.Second, 100*time.Millisecond)
ts.SetServer(1)
require.Eventually(t, func() bool { return !ts.Candidate(0).IsLeader() }, 15*time.Second, 100*time.Millisecond)
// TODO: Check that new candidate doesn't become leader before old candidate loses it
// require.False(t, ts.Candidate(1).IsLeader())
// New candidate must not get leadership before old candidate loses it
require.False(t, ts.Candidate(1).IsLeader())
require.Eventually(t, ts.Candidate(1).IsLeader, 15*time.Second, 100*time.Millisecond)
require.Eventually(t, ts.Candidate(1).IsLeader, 20*time.Second, 100*time.Millisecond)
}