Make force state less log spammy

candidate.go

@@ -27,6 +27,7 @@ type Candidate struct {
 
 	votes      map[string]*vote
 	state      CandidateState
+	forceState CandidateState
 	firstYes   time.Time
 	mu         sync.RWMutex
 }
@@ -34,7 +35,8 @@ type Candidate struct {
 type CandidateState int
 
 const (
-	StateLeader CandidateState = iota
+	StateUndefined CandidateState = iota
+	StateLeader
 	StateNotLeader
 
 	maxVotePeriod  = 5 * time.Second
@@ -60,6 +62,7 @@ func NewCandidate(numVoters int, signingKey string) *Candidate {
 		signingKey: []byte(signingKey),
 		votes:      map[string]*vote{},
 		state:      StateNotLeader,
+		forceState: getForceState(),
 		stop:       make(chan bool),
 		done:       make(chan bool),
 		c:          change,
@@ -68,6 +71,11 @@ func NewCandidate(numVoters int, signingKey string) *Candidate {
 		},
 	}
 
+	if c.forceState != StateUndefined {
+		log.Printf("[elect] state forced to %s", StateName[c.forceState])
+		c.state = c.forceState
+	}
+
 	go c.loop()
 
 	return c
@@ -210,30 +218,9 @@ func (c *Candidate) elect(v *vote) {
 		c.c <- state
 	}()
 
-	switch *electForceState {
-	case "":
-		// Not forced
-
-	case "leader":
-		log.Printf("[elect] state forced to leader")
-
-		state = StateLeader
-
+	if c.forceState != StateUndefined {
+		c.state = c.forceState
 		return
-
-	case "not-leader":
-		fallthrough
-	case "not_leader":
-		fallthrough
-	case "notleader":
-		log.Printf("[elect] state forced to not leader")
-
-		state = StateNotLeader
-
-		return
-
-	default:
-		panic("invalid --elect-force-state")
 	}
 
 	if v != nil {
@@ -299,3 +286,23 @@ func (c *Candidate) loop() {
 		}
 	}
 }
+
+func getForceState() CandidateState {
+	switch *electForceState {
+	case "":
+		return StateUndefined
+
+	case "leader":
+		return StateLeader
+
+	case "not-leader":
+		fallthrough
+	case "not_leader":
+		fallthrough
+	case "notleader":
+		return StateNotLeader
+
+	default:
+		panic("invalid --elect-force-state")
+	}
+}