misc/recentrunes
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Avoid constantly calling toLowerCase()

Browse Source
This commit is contained in:
Ian Gulliver
2014-07-02 09:31:09 -07:00
parent 987defe93e
commit fc5dc49e72
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
recentrunes.js
View File

@@ -731,12 +731,16 @@ rr.SingleLineText = function() {
* @return {rr.typeFilter} * @return {rr.typeFilter}
*/ */
rr.GroupSiblings = function(parentName, childNames) { rr.GroupSiblings = function(parentName, childNames) {
parentName = parentName.toUpperCase();
childNames = childNames.map(function(name) {
return name.toUpperCase();
});
return function(node) { return function(node) {
if (childNames.indexOf(node.nodeName.toLowerCase()) == -1) { if (childNames.indexOf(node.nodeName) == -1) {
return; return;
} }
if (node.previousSibling && if (node.previousSibling &&
node.previousSibling.nodeName.toLowerCase() == parentName) { node.previousSibling.nodeName == parentName) {
// Group with previous node. // Group with previous node.
node.previousSibling.appendChild(node); node.previousSibling.appendChild(node);
return; return;
@@ -754,8 +758,9 @@ rr.GroupSiblings = function(parentName, childNames) {
* @return {rr.typeFilter} * @return {rr.typeFilter}
*/ */
rr.RenameElement = function(oldName, newName) { rr.RenameElement = function(oldName, newName) {
oldName = oldName.toUpperCase();
return function(node) { return function(node) {
if (node.nodeName.toLowerCase() != oldName) { if (node.nodeName != oldName) {
return; return;
} }
var newNode = document.createElement(newName); var newNode = document.createElement(newName);
@@ -773,8 +778,9 @@ rr.RenameElement = function(oldName, newName) {
* @return {rr.typeFilter} * @return {rr.typeFilter}
*/ */
rr.SplitElementAndNest = function(originalName, newNames) { rr.SplitElementAndNest = function(originalName, newNames) {
originalName = originalName.toUpperCase();
return function(node) { return function(node) {
if (node.nodeName.toLowerCase() != originalName) { if (node.nodeName != originalName) {
return; return;
} }
var outerNode, innerNode; var outerNode, innerNode;