Cleanups from documentation effort.

This commit is contained in:
Ian Gulliver
2014-06-08 11:38:40 -07:00
parent 1b4b55ac23
commit 94491649a1

View File

@@ -300,11 +300,11 @@ Cosmopolite.prototype.shutdown = function() {
* @param {Cosmopolite.typeSubjectLoose} subject * @param {Cosmopolite.typeSubjectLoose} subject
* @param {?number=} opt_messages Number of recent messages to request; * @param {?number=} opt_messages Number of recent messages to request;
* 0 for none, -1 for all * 0 for none, -1 for all
* @param {?number=} opt_last_id ID of last message received; fetch messages * @param {?number=} opt_lastID ID of last message received; fetch messages
* since * since
* @return {Promise} * @return {Promise}
*/ */
Cosmopolite.prototype.subscribe = function(subject, opt_messages, opt_last_id) { Cosmopolite.prototype.subscribe = function(subject, opt_messages, opt_lastID) {
return new Promise(function(resolve, reject) { return new Promise(function(resolve, reject) {
/** @type {Cosmopolite.typeSubject} */ /** @type {Cosmopolite.typeSubject} */
var canonicalSubject = this.canonicalSubject_(subject); var canonicalSubject = this.canonicalSubject_(subject);
@@ -325,8 +325,8 @@ Cosmopolite.prototype.subscribe = function(subject, opt_messages, opt_last_id) {
if (opt_messages) { if (opt_messages) {
args['messages'] = opt_messages; args['messages'] = opt_messages;
} }
if (opt_last_id != null) { if (opt_lastID != null) {
args['last_id'] = opt_last_id; args['last_id'] = opt_lastID;
} }
this.sendRPC_('subscribe', args, function(response) { this.sendRPC_('subscribe', args, function(response) {
@@ -850,15 +850,15 @@ Cosmopolite.prototype.onReconnect_ = function() {
continue; continue;
} }
/** @type {number} */ /** @type {number} */
var last_id = 0; var lastID = 0;
if (subscription.messages.length > 0) { if (subscription.messages.length > 0) {
last_id = subscription.messages[subscription.messages.length - 1]['id']; lastID = subscription.messages[subscription.messages.length - 1]['id'];
} }
rpcs.push({ rpcs.push({
'command': 'subscribe', 'command': 'subscribe',
'arguments': { 'arguments': {
'subject': subscription['subject'], 'subject': subscription['subject'],
'last_id': last_id 'last_id': lastID
} }
}); });
} }
@@ -892,7 +892,6 @@ Cosmopolite.prototype.createChannel_ = function() {
'onSuccess': this.onCreateChannel_ 'onSuccess': this.onCreateChannel_
} }
]; ];
// sendRPCs instead of sendRPC so we don't queue.
this.sendRPCs_(rpcs); this.sendRPCs_(rpcs);
}; };