lint/compiler cleanups

This commit is contained in:
Ian Gulliver
2014-05-31 11:51:16 -07:00
parent 54dcc98b00
commit 0ab2fe620c

View File

@@ -45,7 +45,8 @@ String.prototype.hashCode = function() {
* @param {?string=} opt_namespace * @param {?string=} opt_namespace
* @param {?string=} opt_trackingID * @param {?string=} opt_trackingID
*/ */
var Cosmopolite = function(opt_callbacks, opt_urlPrefix, opt_namespace, opt_trackingID) { var Cosmopolite = function(
opt_callbacks, opt_urlPrefix, opt_namespace, opt_trackingID) {
/** /**
* @type {Cosmopolite.typeCallbacks} * @type {Cosmopolite.typeCallbacks}
* @private * @private
@@ -136,10 +137,10 @@ var Cosmopolite = function(opt_callbacks, opt_urlPrefix, opt_namespace, opt_trac
'storage': 'none', 'storage': 'none',
'clientId': localStorage[this.namespace_ + ':tracking_client_id'] 'clientId': localStorage[this.namespace_ + ':tracking_client_id']
}; };
var saveCallback = function(analytics) { var saveCallback = (function(analytics) {
localStorage[this.namespace_ + ':tracking_client_id'] = localStorage[this.namespace_ + ':tracking_client_id'] =
analytics.get('clientId'); analytics.get('clientId');
}.bind(this); }).bind(this);
window[this.analyticsObjName_] = { window[this.analyticsObjName_] = {
'l': 1 * new Date(), 'l': 1 * new Date(),
'q': [ 'q': [
@@ -326,7 +327,7 @@ Cosmopolite.prototype.subscribe = function(subject, opt_messages, opt_last_id) {
resolve(); resolve();
if (this.analyticsObj_) { if (this.analyticsObj_) {
this.analyticsObj_( this.analyticsObj_(
'send', 'event', 'cosmopolite', 'subscribe', subjectString); 'send', 'event', 'cosmopolite', 'subscribe', subjectString);
} }
} else { } else {
delete this.subscriptions_[subjectString]; delete this.subscriptions_[subjectString];
@@ -613,7 +614,7 @@ Cosmopolite.prototype.onLoad_ = function() {
} }
if (this.analyticsObjName_) { if (this.analyticsObjName_) {
/** /**
* @type {Object} * @type {function(...)}
* @private * @private
*/ */
this.analyticsObj_ = window[this.analyticsObjName_]; this.analyticsObj_ = window[this.analyticsObjName_];
@@ -879,7 +880,6 @@ Cosmopolite.prototype.onReconnect_ = function() {
for (var subject in this.subscriptions_) { for (var subject in this.subscriptions_) {
/** @type {Cosmopolite.typeSubscription_} */ /** @type {Cosmopolite.typeSubscription_} */
var subscription = this.subscriptions_[subject]; var subscription = this.subscriptions_[subject];
/** @type {Cosmopolite.typeSubject} */
if (subscription.state != Cosmopolite.SubscriptionState_.ACTIVE) { if (subscription.state != Cosmopolite.SubscriptionState_.ACTIVE) {
continue; continue;
} }