From 14c5a59a8868fed7f5a3237e5ce017aa4d949ee4 Mon Sep 17 00:00:00 2001 From: mehanizm Date: Thu, 24 Mar 2022 18:27:56 +0300 Subject: [PATCH] impr: add conversion function for datetime airtable fields #11 --- field-converter.go | 24 ++++++++++++++++++++ field-converter_test.go | 49 +++++++++++++++++++++++++++++++++++++++++ get-records_test.go | 2 +- mock-response_test.go | 5 ++++- 4 files changed, 78 insertions(+), 2 deletions(-) create mode 100644 field-converter.go create mode 100644 field-converter_test.go diff --git a/field-converter.go b/field-converter.go new file mode 100644 index 0000000..c0afdb0 --- /dev/null +++ b/field-converter.go @@ -0,0 +1,24 @@ +package airtable + +import ( + "errors" + "time" +) + +const ( + dateTimeFormat = "2006-01-02T15:04:05.000Z" +) + +var ErrNotDateTime = errors.New("field is not date time") + +func ToDateTime(field interface{}) (time.Time, error) { + fS, err := field.(string) + if !err { + return time.Time{}, ErrNotDateTime + } + return time.Parse(dateTimeFormat, fS) +} + +func FromDateTime(t time.Time) interface{} { + return t.Format(dateTimeFormat) +} diff --git a/field-converter_test.go b/field-converter_test.go new file mode 100644 index 0000000..03d1784 --- /dev/null +++ b/field-converter_test.go @@ -0,0 +1,49 @@ +package airtable + +import ( + "reflect" + "testing" + "time" +) + +func TestToDateTime(t *testing.T) { + tests := []struct { + name string + field interface{} + want time.Time + wantErr bool + }{ + {"not string", interface{}(1), time.Time{}, true}, + {"string not time", interface{}("hello"), time.Time{}, true}, + {"string time", interface{}("2022-03-24T11:12:13.000Z"), time.Date(2022, 0o3, 24, 11, 12, 13, 0, time.UTC), false}, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + got, err := ToDateTime(tt.field) + if (err != nil) != tt.wantErr { + t.Errorf("ToDateTime() error = %v, wantErr %v", err, tt.wantErr) + return + } + if !reflect.DeepEqual(got, tt.want) { + t.Errorf("ToDateTime() = %v, want %v", got, tt.want) + } + }) + } +} + +func TestFromDateTime(t *testing.T) { + tests := []struct { + name string + t time.Time + want interface{} + }{ + {"positive", time.Date(2022, 0o3, 24, 11, 12, 13, 1, time.UTC), interface{}("2022-03-24T11:12:13.000Z")}, + } + for _, tt := range tests { + t.Run(tt.name, func(t *testing.T) { + if got := FromDateTime(tt.t); got.(string) != tt.want.(string) { + t.Errorf("FromDateTime() = %v, want %v", got, tt.want) + } + }) + } +} diff --git a/get-records_test.go b/get-records_test.go index 7de2fd7..9e32e6a 100644 --- a/get-records_test.go +++ b/get-records_test.go @@ -39,7 +39,7 @@ func TestGetRecordsConfig_Do(t *testing.T) { } table.client.baseURL = mockErrorResponse(400).URL - records, err = table.GetRecords().Do() + _, err = table.GetRecords().Do() if err == nil { t.Errorf("there should be an err, but was nil") } diff --git a/mock-response_test.go b/mock-response_test.go index 6f4814a..385fba1 100644 --- a/mock-response_test.go +++ b/mock-response_test.go @@ -23,7 +23,10 @@ func mockResponse(paths ...string) *httptest.Server { } return httptest.NewServer(http.HandlerFunc(func(rw http.ResponseWriter, r *http.Request) { - rw.Write(mockData) + _, err := rw.Write(mockData) + if err != nil { + log.Fatal(err) + } })) }