Fix typo

.clang-format

@@ -0,0 +1,151 @@
+---
+Language:        Cpp
+# BasedOnStyle:  Google
+AccessModifierOffset: -1
+AlignAfterOpenBracket: Align
+AlignConsecutiveAssignments: false
+AlignConsecutiveDeclarations: false
+AlignEscapedNewlines: Left
+AlignOperands:   true
+AlignTrailingComments: true
+AllowAllParametersOfDeclarationOnNextLine: true
+AllowShortBlocksOnASingleLine: false
+AllowShortCaseLabelsOnASingleLine: false
+AllowShortFunctionsOnASingleLine: All
+AllowShortIfStatementsOnASingleLine: true
+AllowShortLoopsOnASingleLine: true
+AlwaysBreakAfterDefinitionReturnType: None
+AlwaysBreakAfterReturnType: None
+AlwaysBreakBeforeMultilineStrings: true
+AlwaysBreakTemplateDeclarations: Yes
+BinPackArguments: true
+BinPackParameters: true
+BraceWrapping:   
+  AfterClass:      false
+  AfterControlStatement: false
+  AfterEnum:       false
+  AfterFunction:   false
+  AfterNamespace:  false
+  AfterObjCDeclaration: false
+  AfterStruct:     false
+  AfterUnion:      false
+  AfterExternBlock: false
+  BeforeCatch:     false
+  BeforeElse:      false
+  IndentBraces:    false
+  SplitEmptyFunction: true
+  SplitEmptyRecord: true
+  SplitEmptyNamespace: true
+BreakBeforeBinaryOperators: None
+BreakBeforeBraces: Attach
+BreakBeforeInheritanceComma: false
+BreakInheritanceList: BeforeColon
+BreakBeforeTernaryOperators: true
+BreakConstructorInitializersBeforeComma: false
+BreakConstructorInitializers: BeforeColon
+BreakAfterJavaFieldAnnotations: false
+BreakStringLiterals: true
+ColumnLimit:     80
+CommentPragmas:  '^ IWYU pragma:'
+CompactNamespaces: false
+ConstructorInitializerAllOnOneLineOrOnePerLine: true
+ConstructorInitializerIndentWidth: 4
+ContinuationIndentWidth: 4
+Cpp11BracedListStyle: true
+DerivePointerAlignment: true
+DisableFormat:   false
+ExperimentalAutoDetectBinPacking: false
+FixNamespaceComments: true
+ForEachMacros:   
+  - foreach
+  - Q_FOREACH
+  - BOOST_FOREACH
+IncludeBlocks:   Preserve
+IncludeCategories: 
+  - Regex:           '^<ext/.*\.h>'
+    Priority:        2
+  - Regex:           '^<.*\.h>'
+    Priority:        1
+  - Regex:           '^<.*'
+    Priority:        2
+  - Regex:           '.*'
+    Priority:        3
+IncludeIsMainRegex: '([-_](test|unittest))?$'
+IndentCaseLabels: true
+IndentPPDirectives: None
+IndentWidth:     2
+IndentWrappedFunctionNames: false
+JavaScriptQuotes: Leave
+JavaScriptWrapImports: true
+KeepEmptyLinesAtTheStartOfBlocks: false
+MacroBlockBegin: ''
+MacroBlockEnd:   ''
+MaxEmptyLinesToKeep: 1
+NamespaceIndentation: None
+ObjCBinPackProtocolList: Never
+ObjCBlockIndentWidth: 2
+ObjCSpaceAfterProperty: false
+ObjCSpaceBeforeProtocolList: true
+PenaltyBreakAssignment: 2
+PenaltyBreakBeforeFirstCallParameter: 1
+PenaltyBreakComment: 300
+PenaltyBreakFirstLessLess: 120
+PenaltyBreakString: 1000
+PenaltyBreakTemplateDeclaration: 10
+PenaltyExcessCharacter: 1000000
+PenaltyReturnTypeOnItsOwnLine: 200
+PointerAlignment: Left
+RawStringFormats: 
+  - Language:        Cpp
+    Delimiters:      
+      - cc
+      - CC
+      - cpp
+      - Cpp
+      - CPP
+      - 'c++'
+      - 'C++'
+    CanonicalDelimiter: ''
+    BasedOnStyle:    google
+  - Language:        TextProto
+    Delimiters:      
+      - pb
+      - PB
+      - proto
+      - PROTO
+    EnclosingFunctions: 
+      - EqualsProto
+      - EquivToProto
+      - PARSE_PARTIAL_TEXT_PROTO
+      - PARSE_TEST_PROTO
+      - PARSE_TEXT_PROTO
+      - ParseTextOrDie
+      - ParseTextProtoOrDie
+    CanonicalDelimiter: ''
+    BasedOnStyle:    google
+ReflowComments:  true
+SortIncludes:    true
+SortUsingDeclarations: true
+SpaceAfterCStyleCast: false
+SpaceAfterTemplateKeyword: true
+SpaceBeforeAssignmentOperators: true
+SpaceBeforeCpp11BracedList: false
+SpaceBeforeCtorInitializerColon: true
+SpaceBeforeInheritanceColon: true
+SpaceBeforeParens: ControlStatements
+SpaceBeforeRangeBasedForLoopColon: true
+SpaceInEmptyParentheses: false
+SpacesBeforeTrailingComments: 2
+SpacesInAngles:  false
+SpacesInContainerLiterals: true
+SpacesInCStyleCastParentheses: false
+SpacesInParentheses: false
+SpacesInSquareBrackets: false
+Standard:        Auto
+StatementMacros: 
+  - Q_UNUSED
+  - QT_REQUIRE_VERSION
+TabWidth:        8
+UseTab:          Never
+...
+

.gitignore

@@ -1,2 +1,3 @@
 *.a
 *.o
+*.so

Makefile

@@ -1,7 +1,9 @@
 FIRE_CXX ?= clang++
-FIRE_CXXFLAGS ?= -O3 -std=gnu++2a -Wall -Werror
+FIRE_CXXFLAGS ?= -O3 -std=gnu++2a -Wall -Werror -Wextra -fPIE -fPIC -fstack-protector-strong -fsanitize=safe-stack -fsanitize=safe-stack
+FIRE_LDFLAGS ?= -fuse-ld=gold -flto -Wl,-z,relro -Wl,-z,now
+FIRE_LDLIBS ?= -lglog
 
-all: firebuf.a firebuf.o
+all: firebuf.a firebuf.o firebuf.so
 
 objects = stream_buffer.o buffer.o
 
@@ -9,14 +11,25 @@ firebuf.a: $(objects)
 	ar rcs $@ $^
 
 firebuf.o: $(objects)
-	ld --relocatable --output=$@ $+
+	gold -z relro -z now -r --output=$@ $+
+
+firebuf.so: $(objects)
+	$(FIRE_CXX) $(FIRE_CXXFLAGS) $(FIRE_LDFLAGS) -shared -o $@ $+ $(FIRE_LDLIBS)
 
 %.o: %.cc *.h Makefile
 	$(FIRE_CXX) $(FIRE_CXXFLAGS) -c -o $@ $<
 
 clean:
-	rm --force *.o *.a
+	rm --force *.so *.o *.a
 
 asan:
 	$(MAKE) clean
-	FIRE_CXXFLAGS="-O1 -g -fsanitize=address -fno-omit-frame-pointer -std=gnu++2a -Wall -Werror" $(MAKE) all
+	FIRE_CXXFLAGS="-O1 -g -fsanitize=address -fno-omit-frame-pointer -std=gnu++2a -fPIE -fPIC" $(MAKE) all
+
+tsan:
+	$(MAKE) clean
+	FIRE_CXXFLAGS="-O1 -g -fsanitize=thread -std=gnu++2a -fPIE -fPIC" $(MAKE) all
+
+ubsan:
+	$(MAKE) clean
+	FIRE_CXXFLAGS="-O1 -g -fsanitize=undefined -std=gnu++2a -fPIE -fPIC" $(MAKE) all

buffer.cc

@@ -3,12 +3,9 @@
 namespace firebuf {
 
 ConstBuffer::ConstBuffer(const char *buf, size_t len)
-		: const_buf_(buf),
+    : const_buf_(buf), len_(len) {}
-		  len_(len) {}
 
-size_t ConstBuffer::ReadMaxLen() const {
+size_t ConstBuffer::ReadMaxLen() const { return len_ - start_; }
-	return len_ - start_;
-}
 
 const char *ConstBuffer::Read(size_t len) {
   if (ReadMaxLen() < len) {
@@ -27,38 +24,24 @@ bool ConstBuffer::Discard(size_t len) {
   return true;
 }
 
-void ConstBuffer::ResetRead() {
+void ConstBuffer::ResetRead() { start_ = commit_; }
-	start_ = commit_;
-}
 
-void ConstBuffer::Commit() {
+void ConstBuffer::Commit() { commit_ = start_; }
-	commit_ = start_;
-}
-
-void ConstBuffer::Reset() {
-	commit_ = start_ = 0;
-}
 
+void ConstBuffer::Reset() { commit_ = start_ = 0; }
 
 Buffer::Buffer(char *buf, size_t size, size_t len)
-		: ConstBuffer(buf, size),
+    : ConstBuffer(buf, size), buf_(buf), size_(size) {
-		  buf_(buf),
-		  size_(size) {
   len_ = len;
 }
 
-Buffer::Buffer(size_t size)
+Buffer::Buffer(size_t size) : Buffer(new char[size], size, 0) {
-		: Buffer(new char[size], size, 0) {
   own_buf_.reset(buf_);
 }
 
-char *Buffer::WritePtr() {
+char *Buffer::WritePtr() { return &buf_[len_]; }
-	return &buf_[len_];
-}
 
-size_t Buffer::WriteMaxLen() const {
+size_t Buffer::WriteMaxLen() const { return size_ - len_; }
-	return size_ - len_;
-}
 
 bool Buffer::Write(const std::string_view &str) {
   if (WriteMaxLen() < str.size()) {

buffer.h

@@ -12,7 +12,8 @@ class ConstBuffer {
 
   [[nodiscard]] size_t ReadMaxLen() const;
   [[nodiscard]] virtual const char *Read(size_t len);
-	template<class T> [[nodiscard]] const T *ReadObj();
+  template <class T>
+  [[nodiscard]] const T *ReadObj();
 
   bool Discard(size_t len);  // like Read() but don't use the result
   void ResetRead();          // next read from last commit
@@ -47,7 +48,8 @@ class Buffer : public ConstBuffer {
   const size_t size_;
 };
 
-template<class T> const T *ConstBuffer::ReadObj() {
+template <class T>
+const T *ConstBuffer::ReadObj() {
   if (ReadMaxLen() < sizeof(T)) {
     return nullptr;
   }

stream_buffer.cc

@@ -2,11 +2,13 @@
 
 namespace firebuf {
 
-StreamBuffer::StreamBuffer(int sock, size_t size)
+StreamBuffer::StreamBuffer(int sock, size_t size) : Buffer(size), sock_(sock) {}
-		: Buffer(size),
-		  sock_(sock) {}
 
 bool StreamBuffer::Refill() {
+  if (WriteMaxLen() == 0) {
+    LOG(ERROR) << "buffer full";
+    return false;
+  }
   auto read_len = read(sock_, WritePtr(), WriteMaxLen());
   if (read_len == -1) {
     if (errno == EINTR) {