2.6 KiB
2.6 KiB
Bugs
- Inbox answer validation isn't atomic with resolving the question
CheckResponsereads open state outside the write transaction andRespondupdates by id alone (internal/agents/respond.go:26–34,:93;internal/store/inbox.go:140), so two concurrent answers both land, or a withdrawal is overwritten. Condition the update onstate='open', check RowsAffected, roll back the batch on conflict and return 409. - A Codex RPC can deadlock the reader it waits on
drivecallsSteersynchronously whilereadLooppushes notifications into a 256-entry channel (internal/codex/session.go:186,:440–476,:598); if it fills before the response is read, each waits on the other. Route RPC responses separately from notification consumption and give RPCs bounded deadlines, without replacing backpressure with an unbounded queue. - Git network operations have no deadline and run under a cross-project lock
exec.Commandhas no context (internal/git/git.go:348–364) and Merge holds the sharedmergeMuthrough fetch (internal/agents/mergein.go:68,:101), so one stalled remote blocks merges in every project. Add contextual deadlines and non-interactive git/SSH, and serialize the network phase per project while keeping same-project ordering. - A malformed file image URL breaks transcript rendering
decodeURIthrows on e.g.file:///tmp/100%.png(web/src/markdown.ts:347), andrenderAllappends events before mounting the composer (web/src/task.ts:608–609), so the rest of the transcript and the composer don't render. Catch the decode error and render the plain fallback link. - Stale reload and focus responses overwrite newer state
loadTasks,loadSessions,loadInboxandsetFocusapply every response, even a late one (web/src/state.ts:158–179,:203–215), so clicking through tabs quickly can snap the pane back. Keep a request sequence per resource key and for focus, and apply only the latest response. - operations.md describes two incompatible event-stream designs
docs/operations.md:320–324says selecting tasks opens dedicated SSE streams, which is stale againstweb/src/state.ts:309–340,:401–414, and says onlyagent.deltais transient thoughadmin.healthis too. Rewrite the Events section to match the current two-stream feed design, and qualify the transaction/event guarantee atdocs/operations.md:7for internal bookkeeping writes.