Centralize snapshot review selection in the store
This commit is contained in:
@@ -41,13 +41,13 @@ func (m *Manager) MergeAfterReview(ctx context.Context, task api.Task, user api.
|
||||
if err != nil {
|
||||
return api.Task{}, err
|
||||
}
|
||||
reviews, err := m.store.ListReviews(ctx, task.Id)
|
||||
reviews, err := m.store.SnapshotReviews(ctx, task.Id, latest.N)
|
||||
if err != nil {
|
||||
return api.Task{}, err
|
||||
}
|
||||
reviewID := ""
|
||||
for _, r := range reviews {
|
||||
if r.SnapshotN == latest.N && r.State == api.ReviewStateRunning {
|
||||
if r.State == api.ReviewStateRunning {
|
||||
reviewID = r.Id
|
||||
}
|
||||
}
|
||||
@@ -99,7 +99,7 @@ func (m *Manager) reviewFinished(reviewID string, deliver bool) {
|
||||
if m.advanceReviews(ctx, r) {
|
||||
return
|
||||
}
|
||||
reviews, err := m.snapshotReviews(ctx, r.TaskId, r.SnapshotN)
|
||||
reviews, err := m.store.SnapshotReviews(ctx, r.TaskId, r.SnapshotN)
|
||||
if err != nil {
|
||||
slog.Error("list snapshot reviews", "task", r.TaskId, "err", err)
|
||||
return
|
||||
|
||||
Reference in New Issue
Block a user