Inbox answer validation isn't atomic with resolving the question

2026-10-16 14:30:50 -07:00
parent f9a5360c33
commit 9f9556b1e4
4 changed files with 20 additions and 8 deletions
@@ -1,7 +1,5 @@
 # Bugs

- Inbox answer validation isn't atomic with resolving the question
-  `CheckResponse` reads open state outside the write transaction and `Respond` updates by id alone (`internal/agents/respond.go:26–34`, `:93`; `internal/store/inbox.go:140`), so two concurrent answers both land, or a withdrawal is overwritten. Condition the update on `state='open'`, check RowsAffected, roll back the batch on conflict and return 409.
 - A malformed file image URL breaks transcript rendering
  `decodeURI` throws on e.g. `file:///tmp/100%.png` (`web/src/markdown.ts:347`), and `renderAll` appends events before mounting the composer (`web/src/task.ts:608–609`), so the rest of the transcript and the composer don't render. Catch the decode error and render the plain fallback link.
 - operations.md describes two incompatible event-stream designs