ai/byre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

Derive pending review stages directly from dependency state

Browse Source
This commit is contained in:
Ian Gulliver
2026-10-22 21:00:45 -07:00
parent f707f628bf
commit 89025bee59
1 changed files with 25 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/store/review.go
+25 -30
View File
@@ -189,57 +189,53 @@ func pendingStages(ctx context.Context, tx *sql.Tx) ([]StageStart, error) {
if err != nil { if err != nil {
return nil, err return nil, err
} }
type defined struct { type reviewRun struct {
review api.Review defID string
defID string byStage map[string]api.Review
} }
found := []defined{} runs := map[SnapshotRef]reviewRun{}
for rows.Next() { for rows.Next() {
d := defined{} defID := ""
d.review, err = scanReview(trailingScanner{rows, []any{&d.defID}}) r, err := scanReview(trailingScanner{rows, []any{&defID}})
if err != nil { if err != nil {
rows.Close() rows.Close()
return nil, err return nil, err
} }
found = append(found, d) if defID == "" {
continue
}
ref := SnapshotRef{TaskID: r.TaskId, N: r.SnapshotN}
run, found := runs[ref]
if !found {
run = reviewRun{defID: defID, byStage: map[string]api.Review{}}
runs[ref] = run
}
run.byStage[r.Stage] = r
} }
err = errors.Join(rows.Err(), rows.Close()) err = errors.Join(rows.Err(), rows.Close())
if err != nil { if err != nil {
return nil, err return nil, err
} }
byTask := map[string]map[string]api.Review{}
for _, d := range found {
if byTask[d.review.TaskId] == nil {
byTask[d.review.TaskId] = map[string]api.Review{}
}
byTask[d.review.TaskId][d.review.Stage] = d.review
}
defs := map[string]api.WorkflowDefinition{} defs := map[string]api.WorkflowDefinition{}
starts := []StageStart{} starts := []StageStart{}
seen := map[string]bool{} for ref, run := range runs {
for _, d := range found { def, loaded := defs[run.defID]
if d.review.State != api.ReviewStateDone || d.defID == "" {
continue
}
def, loaded := defs[d.defID]
if !loaded { if !loaded {
def, err = loadDefinition(ctx, tx, d.defID) def, err = loadDefinition(ctx, tx, run.defID)
if err != nil { if err != nil {
return nil, err return nil, err
} }
defs[d.defID] = def defs[run.defID] = def
} }
byStage := byTask[d.review.TaskId] for _, stage := range workflow.Stages(def) {
for _, next := range workflow.Next(def, d.review.Stage) { if _, started := run.byStage[stage.Stage]; started {
key := d.review.TaskId + "\x00" + next
if _, started := byStage[next]; started || seen[key] {
continue continue
} }
inputs := []api.Review{} inputs := []api.Review{}
after := workflow.After(def, next) after := workflow.After(def, stage.Stage)
for _, a := range after { for _, a := range after {
in := byStage[a] in := run.byStage[a]
if in.State != api.ReviewStateDone { if in.State != api.ReviewStateDone {
break break
} }
@@ -248,8 +244,7 @@ func pendingStages(ctx context.Context, tx *sql.Tx) ([]StageStart, error) {
if len(inputs) != len(after) { if len(inputs) != len(after) {
continue continue
} }
seen[key] = true starts = append(starts, StageStart{TaskID: ref.TaskID, SnapshotN: ref.N, DefinitionID: run.defID, Definition: def, Stage: stage.Stage, Inputs: inputs})
starts = append(starts, StageStart{TaskID: d.review.TaskId, SnapshotN: d.review.SnapshotN, DefinitionID: d.defID, Definition: def, Stage: next, Inputs: inputs})
} }
} }
return starts, nil return starts, nil