Track fixed and ignored review findings
This commit is contained in:
@@ -1,7 +1,10 @@
|
||||
package server
|
||||
|
||||
import (
|
||||
"errors"
|
||||
"net/http"
|
||||
|
||||
"g.fc.run/misc/byre/internal/api"
|
||||
)
|
||||
|
||||
func (s *Server) ListReviews(w http.ResponseWriter, r *http.Request, taskID string) {
|
||||
@@ -18,3 +21,30 @@ func (s *Server) ListReviews(w http.ResponseWriter, r *http.Request, taskID stri
|
||||
}
|
||||
writeJSON(w, http.StatusOK, reviews)
|
||||
}
|
||||
|
||||
func (s *Server) SetFindingState(w http.ResponseWriter, r *http.Request, reviewID string, index int) {
|
||||
req := api.FindingStateUpdate{}
|
||||
if !readJSON(w, r, &req) {
|
||||
return
|
||||
}
|
||||
if !req.State.Valid() {
|
||||
writeError(w, http.StatusBadRequest, errors.New("state must be fixed or ignored"))
|
||||
return
|
||||
}
|
||||
if index < 0 {
|
||||
writeError(w, http.StatusBadRequest, errors.New("index must not be negative"))
|
||||
return
|
||||
}
|
||||
|
||||
err := s.store.SetFindingState(r.Context(), reviewID, index, req.State, actor(r))
|
||||
if err != nil {
|
||||
writeStoreError(w, err)
|
||||
return
|
||||
}
|
||||
review, err := s.store.GetReview(r.Context(), reviewID)
|
||||
if err != nil {
|
||||
writeStoreError(w, err)
|
||||
return
|
||||
}
|
||||
writeJSON(w, http.StatusOK, review)
|
||||
}
|
||||
|
||||
Reference in New Issue
Block a user