ai/byre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 15 Wiki Activity

Add background audits of the default branch's newest commit

Browse Source
This commit is contained in:
Ian Gulliver
2026-10-20 21:08:31 -07:00
parent 1d3c4576ff
commit 5823af6ff9
21 changed files with 745 additions and 357 deletions
Download Patch File Download Diff File Expand all files Collapse all files
internal/store/migrations/077-add-audits.sql
+2
View File
@@ -0,0 +1,2 @@
ALTER TABLE projects ADD COLUMN audit_workflow TEXT NOT NULL DEFAULT '';
ALTER TABLE tasks ADD COLUMN audit TEXT NOT NULL DEFAULT '';
internal/store/store.go
+27 -8
View File
@@ -295,8 +295,16 @@ func (s *Store) ListProjects(ctx context.Context) ([]api.Project, error) {
}
func (s *Store) SetReviewWorkflow(ctx context.Context, id, workflow, actor string) (api.Project, error) {
return s.setProjectWorkflow(ctx, "review_workflow", id, workflow, actor)
}
func (s *Store) SetAuditWorkflow(ctx context.Context, id, workflow, actor string) (api.Project, error) {
return s.setProjectWorkflow(ctx, "audit_workflow", id, workflow, actor)
}
func (s *Store) setProjectWorkflow(ctx context.Context, column, id, workflow, actor string) (api.Project, error) {
err := s.write(ctx, func(tx *sql.Tx, emit emitFunc) error {
res, err := tx.ExecContext(ctx, `UPDATE projects SET review_workflow = ? WHERE id = ?`, workflow, id)
res, err := tx.ExecContext(ctx, `UPDATE projects SET `+column+` = ? WHERE id = ?`, workflow, id)
if err != nil {
return err
}
@@ -367,6 +375,11 @@ func (s *Store) CreateTask(ctx context.Context, t api.Task, frozen *FrozenWorkfl
if t.ParentTaskId != nil {
parentTaskID = *t.ParentTaskId
}
audit := ""
if t.Audit != nil {
audit = *t.Audit
t.Background = true
}
return s.write(ctx, func(tx *sql.Tx, emit emitFunc) error {
if parentTaskID != "" {
open := false
@@ -398,9 +411,9 @@ func (s *Store) CreateTask(ctx context.Context, t api.Task, frozen *FrozenWorkfl
return err
}
_, err = tx.ExecContext(ctx, `
INSERT INTO tasks (id, project_id, title, merge_title, branch, worktree_path, base_ref, port_base, color, status, created_by, created_at, todo_item, forked_from, forked_at, workflow_name, workflow_definition, workflow_brief, workflow_title, workflow_run, workflow_stage, parent_task_id)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
`, t.Id, t.ProjectId, t.Title, mergeTitle, t.Branch, t.WorktreePath, t.BaseRef, t.PortBase, t.Color, string(t.Status), t.CreatedBy, formatTime(t.CreatedAt), todoItem, forkedFrom, forkedAt, workflowName, workflowDefinition, workflowBrief, workflowTitle, workflowRun, workflowStage, parentTaskID)
INSERT INTO tasks (id, project_id, title, merge_title, branch, worktree_path, base_ref, port_base, color, status, created_by, created_at, todo_item, forked_from, forked_at, workflow_name, workflow_definition, workflow_brief, workflow_title, workflow_run, workflow_stage, parent_task_id, audit)
VALUES (?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?)
`, t.Id, t.ProjectId, t.Title, mergeTitle, t.Branch, t.WorktreePath, t.BaseRef, t.PortBase, t.Color, string(t.Status), t.CreatedBy, formatTime(t.CreatedAt), todoItem, forkedFrom, forkedAt, workflowName, workflowDefinition, workflowBrief, workflowTitle, workflowRun, workflowStage, parentTaskID, audit)
if err != nil {
return err
}
@@ -1682,9 +1695,11 @@ func (s *Store) ClearReviewRequests(ctx context.Context) error {
})
}
const projectColumns = `id, name, repo_path, default_branch, remote, created_by, created_at, review_workflow`
const projectColumns = `id, name, repo_path, default_branch, remote, created_by, created_at, review_workflow, audit_workflow`
const taskColumns = `id, project_id, title, merge_title, branch, worktree_path, base_ref, port_base, color, status, created_by, created_at, closed_at, merge_commit, todo_item, forked_from, forked_at, merge_queued_at, workflow_name, workflow_run, workflow_stage, parent_task_id, parent_merge_by, merge_after_review_by != '', state, merging_by != '' OR finalizing != '', discard_state != '' AND status = 'active', (SELECT coalesce(max(seq), 0) FROM events WHERE events.task_id = tasks.id AND kind = 'turn.ended' AND json_extract(payload, '$.summary') = 1)`
const taskColumns = `id, project_id, title, merge_title, branch, worktree_path, base_ref, port_base, color, status, created_by, created_at, closed_at, merge_commit, todo_item, forked_from, forked_at, merge_queued_at, workflow_name, workflow_run, workflow_stage, parent_task_id, parent_merge_by, merge_after_review_by != '', state, merging_by != '' OR finalizing != '', discard_state != '' AND status = 'active', (SELECT coalesce(max(seq), 0) FROM events WHERE events.task_id = tasks.id AND kind = 'turn.ended' AND json_extract(payload, '$.summary') = 1), audit, ` + backgroundExpr
const backgroundExpr = `audit != '' AND NOT EXISTS (SELECT 1 FROM events WHERE events.task_id = tasks.id AND kind IN ('inbox.created', 'task.ready', 'session.error', 'session.rate_limited'))`
const sessionColumns = `id, coalesce(task_id, ''), owner, vendor, model, vendor_session_id, state, role, member, created_by, created_at, forked_from, forked_at, subagents`
@@ -1695,7 +1710,7 @@ type scanner interface {
func scanProject(row scanner) (api.Project, error) {
p := api.Project{}
createdAt := ""
err := row.Scan(&p.Id, &p.Name, &p.RepoPath, &p.DefaultBranch, &p.Remote, &p.CreatedBy, &createdAt, &p.ReviewWorkflow)
err := row.Scan(&p.Id, &p.Name, &p.RepoPath, &p.DefaultBranch, &p.Remote, &p.CreatedBy, &createdAt, &p.ReviewWorkflow, &p.AuditWorkflow)
if err != nil {
return p, err
}
@@ -1719,11 +1734,15 @@ func scanTask(row scanner) (api.Task, error) {
parentTaskID := ""
parentMergeBy := ""
taskState := ""
err := row.Scan(&t.Id, &t.ProjectId, &t.Title, &t.MergeTitle, &t.Branch, &t.WorktreePath, &t.BaseRef, &t.PortBase, &t.Color, &status, &t.CreatedBy, &createdAt, &closedAt, &mergeCommit, &todoItem, &forkedFrom, &forkedAt, &mergeQueuedAt, &workflowName, &workflowRun, &workflowStage, &parentTaskID, &parentMergeBy, &t.MergeAfterReview, &taskState, &t.Merging, &t.Discarding, &t.SummarySeq)
audit := ""
err := row.Scan(&t.Id, &t.ProjectId, &t.Title, &t.MergeTitle, &t.Branch, &t.WorktreePath, &t.BaseRef, &t.PortBase, &t.Color, &status, &t.CreatedBy, &createdAt, &closedAt, &mergeCommit, &todoItem, &forkedFrom, &forkedAt, &mergeQueuedAt, &workflowName, &workflowRun, &workflowStage, &parentTaskID, &parentMergeBy, &t.MergeAfterReview, &taskState, &t.Merging, &t.Discarding, &t.SummarySeq, &audit, &t.Background)
if err != nil {
return t, err
}
t.State = api.TaskState(taskState)
if audit != "" {
t.Audit = &audit
}
if parentTaskID != "" {
t.ParentTaskId = &parentTaskID
}
internal/store/workflow.go
+22 -5
View File
@@ -15,6 +15,7 @@ type FrozenWorkflow struct {
Definition api.WorkflowDefinition
Brief string
Title string
Audit string
}
func (s *Store) ListWorkflows(ctx context.Context) ([]api.WorkflowSummary, error) {
@@ -81,7 +82,7 @@ func (s *Store) PutWorkflow(ctx context.Context, name, from string, def api.Work
if err != nil {
return err
}
err = repointReviews(ctx, tx, emit, from, name, actor)
err = repointProjects(ctx, tx, emit, from, name, actor)
if err != nil {
return err
}
@@ -99,8 +100,13 @@ func (s *Store) PutWorkflow(ctx context.Context, name, from string, def api.Work
})
}
func repointReviews(ctx context.Context, tx *sql.Tx, emit emitFunc, from, to, actor string) error {
rows, err := tx.QueryContext(ctx, `UPDATE projects SET review_workflow = ? WHERE review_workflow = ? RETURNING `+projectColumns, to, from)
func repointProjects(ctx context.Context, tx *sql.Tx, emit emitFunc, from, to, actor string) error {
rows, err := tx.QueryContext(ctx, `
UPDATE projects SET
review_workflow = CASE WHEN review_workflow = ?1 THEN ?2 ELSE review_workflow END,
audit_workflow = CASE WHEN audit_workflow = ?1 THEN ?2 ELSE audit_workflow END
WHERE review_workflow = ?1 OR audit_workflow = ?1
RETURNING `+projectColumns, from, to)
if err != nil {
return err
}
@@ -139,7 +145,7 @@ func (s *Store) DeleteWorkflow(ctx context.Context, name, actor string) error {
if n == 0 {
return fmt.Errorf("%w: no workflow %q", ErrNotFound, name)
}
err = repointReviews(ctx, tx, emit, name, "", actor)
err = repointProjects(ctx, tx, emit, name, "", actor)
if err != nil {
return err
}
@@ -158,7 +164,7 @@ func (s *Store) FreezeWorkflow(ctx context.Context, name string) (FrozenWorkflow
func (s *Store) TaskWorkflow(ctx context.Context, taskID string) (FrozenWorkflow, error) {
f := FrozenWorkflow{}
def := ""
err := s.db.QueryRowContext(ctx, `SELECT workflow_name, workflow_definition, workflow_brief, workflow_title FROM tasks WHERE id = ?`, taskID).Scan(&f.Name, &def, &f.Brief, &f.Title)
err := s.db.QueryRowContext(ctx, `SELECT workflow_name, workflow_definition, workflow_brief, workflow_title, audit FROM tasks WHERE id = ?`, taskID).Scan(&f.Name, &def, &f.Brief, &f.Title, &f.Audit)
if errors.Is(err, sql.ErrNoRows) {
return FrozenWorkflow{}, fmt.Errorf("%w: no task %s", ErrNotFound, taskID)
}
@@ -172,6 +178,17 @@ func (s *Store) TaskWorkflow(ctx context.Context, taskID string) (FrozenWorkflow
return f, err
}
func (s *Store) LastAudit(ctx context.Context, projectID string) (string, bool, error) {
commit := ""
active := false
err := s.db.QueryRowContext(ctx, `
SELECT
coalesce((SELECT audit FROM tasks WHERE project_id = ?1 AND audit != '' ORDER BY rowid DESC LIMIT 1), ''),
EXISTS (SELECT 1 FROM tasks WHERE project_id = ?1 AND audit != '' AND status = ?2)
`, projectID, string(api.TaskStatusActive)).Scan(&commit, &active)
return commit, active, err
}
func (s *Store) RunTasks(ctx context.Context, run string) ([]api.Task, error) {
return s.queryTasks(ctx, `SELECT `+taskColumns+` FROM tasks WHERE workflow_run = ? ORDER BY created_at`, run)
}