Audit of ccbbb58

2026-10-20 22:02:59 -07:00
parent ccbbb5807f
commit 57324fe9a2
5 changed files with 31 additions and 53 deletions
@@ -63,10 +63,6 @@ func (m *Manager) bounceProseQuestion(l *live) claude.HookFunc {
 		if err != nil || !bounce {
 			return map[string]any{}, err
 		}
-		err = m.emit(ctx, l, "byre", "user.message", map[string]any{"text": proseQuestionNudge, "mid_turn": true, "bounce": true})
-		if err != nil {
-			return nil, err
-		}
 		return map[string]any{"decision": "block", "reason": proseQuestionNudge}, nil
 	}
 }
@@ -91,12 +87,14 @@ func (m *Manager) takeBounce(ctx context.Context, l *live, final string) (bool,
 	}

 	m.mu.Lock()
-	defer m.mu.Unlock()
 	if l.asked || l.bounced || l.compacting {
+		m.mu.Unlock()
 		return false, nil
 	}
 	l.bounced = true
-	return true, nil
+	m.mu.Unlock()
+	err = m.emit(ctx, l, "byre", "user.message", map[string]any{"text": proseQuestionNudge, "mid_turn": true, "bounce": true})
+	return err == nil, err
 }

 func (m *Manager) taskGuidance(ctx context.Context, task api.Task) (string, error) {