Store workflow definitions as table rows and drop YAML

internal/store/workflow.go

@@ -3,7 +3,6 @@ package store
 import (
 	"context"
 	"database/sql"
-	"encoding/json"
 	"errors"
 	"fmt"
 
@@ -11,15 +10,16 @@ import (
 )
 
 type FrozenWorkflow struct {
-	Name       string
-	Definition api.WorkflowDefinition
-	Brief      string
-	Title      string
-	Audit      string
+	Name         string
+	DefinitionID string
+	Definition   api.WorkflowDefinition
+	Brief        string
+	Title        string
+	Audit        string
 }
 
 func (s *Store) ListWorkflows(ctx context.Context) ([]api.WorkflowSummary, error) {
-	rows, err := s.db.QueryContext(ctx, `SELECT name, coalesce(json_extract(definition, '$.description'), '') FROM workflows ORDER BY name`)
+	rows, err := s.db.QueryContext(ctx, `SELECT w.name, d.description FROM workflows w JOIN workflow_definitions d ON d.id = w.definition_id ORDER BY w.name`)
 	if err != nil {
 		return nil, err
 	}
@@ -38,26 +38,13 @@ func (s *Store) ListWorkflows(ctx context.Context) ([]api.WorkflowSummary, error
 }
 
 func (s *Store) GetWorkflow(ctx context.Context, name string) (api.WorkflowDefinition, error) {
-	def := ""
-	err := s.db.QueryRowContext(ctx, `SELECT definition FROM workflows WHERE name = ?`, name).Scan(&def)
-	if errors.Is(err, sql.ErrNoRows) {
-		return api.WorkflowDefinition{}, fmt.Errorf("%w: no workflow %q", ErrNotFound, name)
-	}
-	if err != nil {
-		return api.WorkflowDefinition{}, err
-	}
-	w := api.WorkflowDefinition{}
-	err = json.Unmarshal([]byte(def), &w)
-	return w, err
+	f, err := s.FreezeWorkflow(ctx, name)
+	return f.Definition, err
 }
 
 var ErrWorkflowExists = errors.New("workflow exists")
 
 func (s *Store) PutWorkflow(ctx context.Context, name, from string, def api.WorkflowDefinition, actor string) error {
-	b, err := json.Marshal(def)
-	if err != nil {
-		return err
-	}
 	return s.write(ctx, func(tx *sql.Tx, emit emitFunc) error {
 		if from != "" {
 			found := false
@@ -91,8 +78,12 @@ func (s *Store) PutWorkflow(ctx context.Context, name, from string, def api.Work
 				return err
 			}
 		}
-		_, err := tx.ExecContext(ctx, `INSERT INTO workflows (name, definition) VALUES (?, ?)
-			ON CONFLICT (name) DO UPDATE SET definition = excluded.definition`, name, string(b))
+		defID, err := insertDefinition(ctx, tx, def)
+		if err != nil {
+			return err
+		}
+		_, err = tx.ExecContext(ctx, `INSERT INTO workflows (name, definition_id) VALUES (?, ?)
+			ON CONFLICT (name) DO UPDATE SET definition_id = excluded.definition_id`, name, defID)
 		if err != nil {
 			return err
 		}
@@ -154,27 +145,33 @@ func (s *Store) DeleteWorkflow(ctx context.Context, name, actor string) error {
 }
 
 func (s *Store) FreezeWorkflow(ctx context.Context, name string) (FrozenWorkflow, error) {
-	def, err := s.GetWorkflow(ctx, name)
+	f := FrozenWorkflow{Name: name}
+	err := s.db.QueryRowContext(ctx, `SELECT definition_id FROM workflows WHERE name = ?`, name).Scan(&f.DefinitionID)
+	if errors.Is(err, sql.ErrNoRows) {
+		return FrozenWorkflow{}, fmt.Errorf("%w: no workflow %q", ErrNotFound, name)
+	}
 	if err != nil {
 		return FrozenWorkflow{}, err
 	}
-	return FrozenWorkflow{Name: name, Definition: def}, nil
+	f.Definition, err = loadDefinition(ctx, s.db, f.DefinitionID)
+	return f, err
 }
 
 func (s *Store) TaskWorkflow(ctx context.Context, taskID string) (FrozenWorkflow, error) {
 	f := FrozenWorkflow{}
-	def := ""
-	err := s.db.QueryRowContext(ctx, `SELECT workflow_name, workflow_definition, workflow_brief, workflow_title, audit FROM tasks WHERE id = ?`, taskID).Scan(&f.Name, &def, &f.Brief, &f.Title, &f.Audit)
+	defID := sql.NullString{}
+	err := s.db.QueryRowContext(ctx, `SELECT workflow_name, workflow_definition_id, workflow_brief, workflow_title, audit FROM tasks WHERE id = ?`, taskID).Scan(&f.Name, &defID, &f.Brief, &f.Title, &f.Audit)
 	if errors.Is(err, sql.ErrNoRows) {
 		return FrozenWorkflow{}, fmt.Errorf("%w: no task %s", ErrNotFound, taskID)
 	}
 	if err != nil {
 		return FrozenWorkflow{}, err
 	}
-	if f.Name == "" {
+	if !defID.Valid {
 		return FrozenWorkflow{}, fmt.Errorf("%w: task %s has no workflow", ErrNotFound, taskID)
 	}
-	err = json.Unmarshal([]byte(def), &f.Definition)
+	f.DefinitionID = defID.String
+	f.Definition, err = loadDefinition(ctx, s.db, f.DefinitionID)
 	return f, err
 }