ai/byre
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases 14 Wiki Activity

Skip unreviewed-snapshot warning when no reviewer is set

Browse Source
This commit is contained in:
Ian Gulliver
2026-10-22 20:28:40 -07:00
parent eed9b40533
commit 1c0effc244
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
mac/Sources/Byre/MergeDialog.swift
+7 -2
View File
@@ -110,7 +110,12 @@ func confirmMerge(_ taskId: String, _ store: Store, _ overlays: Overlays, keepOp
@MainActor @MainActor
private func reviewWarnings(_ taskId: String, _ f: MergeFacts, _ store: Store, _ leave: @escaping Leave) -> [MergeWarning] { private func reviewWarnings(_ taskId: String, _ f: MergeFacts, _ store: Store, _ leave: @escaping Leave) -> [MergeWarning] {
let task = store.findTask(taskId)
let reviewing = !(store.projects.first { $0.id == task?.projectId }?.reviewWorkflow.isEmpty ?? true)
if f.reviewSnapshot == 0 { if f.reviewSnapshot == 0 {
if !reviewing {
return []
}
return [MergeWarning(text: "These changes haven't been reviewed")] return [MergeWarning(text: "These changes haven't been reviewed")]
} }
var items: [MergeWarning] = [] var items: [MergeWarning] = []
@@ -119,7 +124,7 @@ private func reviewWarnings(_ taskId: String, _ f: MergeFacts, _ store: Store, _
store.jumpTo(taskId, .review(f.reviewSnapshot)) store.jumpTo(taskId, .review(f.reviewSnapshot))
} }
} }
if f.reviewCount == 0 { if f.reviewCount == 0 && reviewing {
items.append(MergeWarning(text: "The latest snapshot hasn't been reviewed", open: open)) items.append(MergeWarning(text: "The latest snapshot hasn't been reviewed", open: open))
} }
if f.reviewRunning { if f.reviewRunning {
@@ -131,7 +136,7 @@ private func reviewWarnings(_ taskId: String, _ f: MergeFacts, _ store: Store, _
if f.reviewFindings > 0 { if f.reviewFindings > 0 {
items.append(MergeWarning(text: "The review of the latest snapshot has \(f.reviewFindings) open finding\(f.reviewFindings == 1 ? "" : "s")", open: open)) items.append(MergeWarning(text: "The review of the latest snapshot has \(f.reviewFindings) open finding\(f.reviewFindings == 1 ? "" : "s")", open: open))
} }
if f.unreviewedChanges { if f.unreviewedChanges && reviewing {
items.append(MergeWarning(text: "Changes since the last snapshot haven't been reviewed")) items.append(MergeWarning(text: "Changes since the last snapshot haven't been reviewed"))
} }
return items return items